PMD Results
The following document contains the results of PMD 6.49.0.
Violations By Priority
Priority 3
org/apache/shiro/web/filter/authc/LogoutFilter.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 87–89 |
org/apache/shiro/web/filter/authz/HostFilter.java
| Rule | Violation | Line |
|---|---|---|
| EmptyControlStatement | Empty else statement | 71–73 |
org/apache/shiro/web/filter/authz/HttpMethodPermissionFilter.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'static' on enum 'HttpMethodAction': nested enums are implicitly static | 100–120 |
| UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'HttpMethodAction(String)': enum constructors are implicitly private | 113–115 |
org/apache/shiro/web/filter/mgt/DefaultFilter.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'DefaultFilter(Class)': enum constructors are implicitly private | 57–59 |
org/apache/shiro/web/mgt/DefaultWebSecurityManager.java
| Rule | Violation | Line |
|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 170–176 |
org/apache/shiro/web/servlet/Cookie.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'DELETED_COOKIE_VALUE': the field is declared in an interface type | 37 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ONE_YEAR': the field is declared in an interface type | 43 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ROOT_PATH': the field is declared in an interface type | 48 |
| UnnecessaryModifier | Unnecessary modifier 'public' on enum 'SameSiteOptions': the enum is declared in an interface type | 53–73 |
org/apache/shiro/web/servlet/ShiroHttpSession.java
| Rule | Violation | Line |
|---|---|---|
| PrimitiveWrapperInstantiation | Do not use `new Long(...)`, prefer `Long.valueOf(...)` | 118 |
org/apache/shiro/web/subject/WebSubject.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'Builder': members of interface types are implicitly public | 58–157 |
| UnnecessaryModifier | Unnecessary modifier 'static' on class 'Builder': types nested within an interface type are implicitly static | 58–157 |
org/apache/shiro/web/tags/SecureTag.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 37 |
Priority 4
org/apache/shiro/web/env/EnvironmentLoader.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 307 |
org/apache/shiro/web/filter/InvalidRequestFilter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 68–70 |
org/apache/shiro/web/filter/authc/AuthenticatingFilter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 124 |
| UselessParentheses | Useless parentheses. | 146 |
org/apache/shiro/web/filter/authc/BasicHttpAuthenticationFilter.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryImport | Unused import 'org.apache.shiro.web.util.WebUtils' | 23 |
| UnnecessaryImport | Unused import 'javax.servlet.http.HttpServletResponse' | 30 |
| UnnecessaryImport | Unused import 'java.util.HashSet' | 31 |
| UnnecessaryImport | Unused import 'java.util.Locale' | 32 |
| UnnecessaryImport | Unused import 'java.util.Set' | 33 |
org/apache/shiro/web/filter/authc/FormAuthenticationFilter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 183 |
org/apache/shiro/web/filter/authc/LogoutFilter.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryImport | Unused import 'org.apache.shiro.util.StringUtils' | 24 |
| UnnecessaryImport | Unused import 'org.apache.shiro.web.filter.mgt.DefaultFilter.logout' | 36 |
org/apache/shiro/web/filter/mgt/PathMatchingFilterChainResolver.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryImport | Unused import 'org.owasp.encoder.Encoder' | 25 |
org/apache/shiro/web/mgt/DefaultWebSessionStorageEvaluator.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 92 |
org/apache/shiro/web/servlet/AbstractShiroFilter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 281 |
| UselessParentheses | Useless parentheses. | 282 |
org/apache/shiro/web/servlet/IniShiroFilter.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 283 |
| UselessParentheses | Useless parentheses. | 283 |
org/apache/shiro/web/servlet/ShiroHttpServletRequest.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 103 |
| UselessParentheses | Useless parentheses. | 198 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.security.Principal' due to existing import 'java.security.Principal' | 224 |
org/apache/shiro/web/servlet/ShiroHttpServletResponse.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 141 |
| UselessParentheses | Useless parentheses. | 144 |
| UselessParentheses | Useless parentheses. | 148 |
| UselessParentheses | Useless parentheses. | 154 |
| UselessParentheses | Useless parentheses. | 156 |
| UselessParentheses | Useless parentheses. | 167 |
| UselessParentheses | Useless parentheses. | 172 |
| UselessParentheses | Useless parentheses. | 174 |
| UselessParentheses | Useless parentheses. | 190 |
| UselessParentheses | Useless parentheses. | 195 |
| UselessParentheses | Useless parentheses. | 196 |
| UselessParentheses | Useless parentheses. | 199 |
| UselessParentheses | Useless parentheses. | 203 |
| UselessParentheses | Useless parentheses. | 221 |
| UselessParentheses | Useless parentheses. | 235 |
| UselessParentheses | Useless parentheses. | 236 |
| UselessParentheses | Useless parentheses. | 302 |
| UselessParentheses | Useless parentheses. | 302 |
| UselessParentheses | Useless parentheses. | 303 |
| UselessParentheses | Useless parentheses. | 327 |
org/apache/shiro/web/servlet/ShiroHttpSession.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 118 |
org/apache/shiro/web/util/RedirectView.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 232 |
| UselessParentheses | Useless parentheses. | 246 |
org/apache/shiro/web/util/WebUtils.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses. | 225 |
| UselessParentheses | Useless parentheses. | 232 |
| UselessParentheses | Useless parentheses. | 251 |
Files
org/apache/shiro/web/env/EnvironmentLoader.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 307 |
org/apache/shiro/web/filter/InvalidRequestFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 68–70 |
org/apache/shiro/web/filter/authc/AuthenticatingFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 124 |
| UselessParentheses | Useless parentheses. | 4 | 146 |
org/apache/shiro/web/filter/authc/BasicHttpAuthenticationFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryImport | Unused import 'org.apache.shiro.web.util.WebUtils' | 4 | 23 |
| UnnecessaryImport | Unused import 'javax.servlet.http.HttpServletResponse' | 4 | 30 |
| UnnecessaryImport | Unused import 'java.util.HashSet' | 4 | 31 |
| UnnecessaryImport | Unused import 'java.util.Locale' | 4 | 32 |
| UnnecessaryImport | Unused import 'java.util.Set' | 4 | 33 |
org/apache/shiro/web/filter/authc/FormAuthenticationFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 183 |
org/apache/shiro/web/filter/authc/LogoutFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryImport | Unused import 'org.apache.shiro.util.StringUtils' | 4 | 24 |
| UnnecessaryImport | Unused import 'org.apache.shiro.web.filter.mgt.DefaultFilter.logout' | 4 | 36 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 87–89 |
org/apache/shiro/web/filter/authz/HostFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyControlStatement | Empty else statement | 3 | 71–73 |
org/apache/shiro/web/filter/authz/HttpMethodPermissionFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'static' on enum 'HttpMethodAction': nested enums are implicitly static | 3 | 100–120 |
| UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'HttpMethodAction(String)': enum constructors are implicitly private | 3 | 113–115 |
org/apache/shiro/web/filter/mgt/DefaultFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'private' on constructor 'DefaultFilter(Class)': enum constructors are implicitly private | 3 | 57–59 |
org/apache/shiro/web/filter/mgt/PathMatchingFilterChainResolver.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryImport | Unused import 'org.owasp.encoder.Encoder' | 4 | 25 |
org/apache/shiro/web/mgt/DefaultWebSecurityManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 170–176 |
org/apache/shiro/web/mgt/DefaultWebSessionStorageEvaluator.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 92 |
org/apache/shiro/web/servlet/AbstractShiroFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 281 |
| UselessParentheses | Useless parentheses. | 4 | 282 |
org/apache/shiro/web/servlet/Cookie.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'DELETED_COOKIE_VALUE': the field is declared in an interface type | 3 | 37 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ONE_YEAR': the field is declared in an interface type | 3 | 43 |
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'ROOT_PATH': the field is declared in an interface type | 3 | 48 |
| UnnecessaryModifier | Unnecessary modifier 'public' on enum 'SameSiteOptions': the enum is declared in an interface type | 3 | 53–73 |
org/apache/shiro/web/servlet/IniShiroFilter.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 283 |
| UselessParentheses | Useless parentheses. | 4 | 283 |
org/apache/shiro/web/servlet/ShiroHttpServletRequest.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 103 |
| UselessParentheses | Useless parentheses. | 4 | 198 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.security.Principal' due to existing import 'java.security.Principal' | 4 | 224 |
org/apache/shiro/web/servlet/ShiroHttpServletResponse.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 141 |
| UselessParentheses | Useless parentheses. | 4 | 144 |
| UselessParentheses | Useless parentheses. | 4 | 148 |
| UselessParentheses | Useless parentheses. | 4 | 154 |
| UselessParentheses | Useless parentheses. | 4 | 156 |
| UselessParentheses | Useless parentheses. | 4 | 167 |
| UselessParentheses | Useless parentheses. | 4 | 172 |
| UselessParentheses | Useless parentheses. | 4 | 174 |
| UselessParentheses | Useless parentheses. | 4 | 190 |
| UselessParentheses | Useless parentheses. | 4 | 195 |
| UselessParentheses | Useless parentheses. | 4 | 196 |
| UselessParentheses | Useless parentheses. | 4 | 199 |
| UselessParentheses | Useless parentheses. | 4 | 203 |
| UselessParentheses | Useless parentheses. | 4 | 221 |
| UselessParentheses | Useless parentheses. | 4 | 235 |
| UselessParentheses | Useless parentheses. | 4 | 236 |
| UselessParentheses | Useless parentheses. | 4 | 302 |
| UselessParentheses | Useless parentheses. | 4 | 302 |
| UselessParentheses | Useless parentheses. | 4 | 303 |
| UselessParentheses | Useless parentheses. | 4 | 327 |
org/apache/shiro/web/servlet/ShiroHttpSession.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrimitiveWrapperInstantiation | Do not use `new Long(...)`, prefer `Long.valueOf(...)` | 3 | 118 |
| UselessParentheses | Useless parentheses. | 4 | 118 |
org/apache/shiro/web/subject/WebSubject.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on class 'Builder': members of interface types are implicitly public | 3 | 58–157 |
| UnnecessaryModifier | Unnecessary modifier 'static' on class 'Builder': types nested within an interface type are implicitly static | 3 | 58–157 |
org/apache/shiro/web/tags/SecureTag.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'log'. | 3 | 37 |
org/apache/shiro/web/util/RedirectView.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 232 |
| UselessParentheses | Useless parentheses. | 4 | 246 |
org/apache/shiro/web/util/WebUtils.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses. | 4 | 225 |
| UselessParentheses | Useless parentheses. | 4 | 232 |
| UselessParentheses | Useless parentheses. | 4 | 251 |