PMD Results

The following document contains the results of PMD 6.55.0.

Violations By Priority

Priority 2

org/apache/shiro/util/AntPathMatcher.java
Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 224
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 377

Priority 3

org/apache/shiro/mgt/AbstractRememberMeManager.java
Rule Violation Line
UnnecessarySemicolon Unnecessary semicolon 83
org/apache/shiro/realm/ldap/JndiLdapContextFactory.java
Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 514–529
org/apache/shiro/realm/text/PropertiesRealm.java
Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 294–296
org/apache/shiro/session/mgt/eis/MemorySessionDAO.java
Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'LOGGER'. 58
org/apache/shiro/util/AntPathMatcher.java
Rule Violation Line
CollapsibleIfStatements These nested if statements could be combined 285–288
CollapsibleIfStatements These nested if statements could be combined 304–307
CollapsibleIfStatements These nested if statements could be combined 326–329
CollapsibleIfStatements These nested if statements could be combined 370–372
JumbledIncrementer Avoid modifying an outer loop incrementer in an inner loop for update expression 424–430

Priority 4

org/apache/shiro/SecurityUtils.java
Rule Violation Line
UselessParentheses Useless parentheses. 56
org/apache/shiro/authc/SimpleAccount.java
Rule Violation Line
UselessParentheses Useless parentheses. 466
UselessParentheses Useless parentheses. 484
org/apache/shiro/authc/SimpleAuthenticationInfo.java
Rule Violation Line
UselessParentheses Useless parentheses. 285
org/apache/shiro/authc/pam/AllSuccessfulStrategy.java
Rule Violation Line
UselessParentheses Useless parentheses. 85
org/apache/shiro/authz/SimpleRole.java
Rule Violation Line
UselessParentheses Useless parentheses. 98
UselessParentheses Useless parentheses. 108
org/apache/shiro/jndi/JndiLocator.java
Rule Violation Line
UselessParentheses Useless parentheses. 66
org/apache/shiro/mgt/DefaultSessionStorageEvaluator.java
Rule Violation Line
UselessParentheses Useless parentheses. 63
org/apache/shiro/realm/ldap/JndiLdapContextFactory.java
Rule Violation Line
UselessParentheses Useless parentheses. 473
UselessParentheses Useless parentheses. 522
UselessParentheses Useless parentheses. 523
UselessParentheses Useless parentheses. 524
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'javax.naming.AuthenticationException' due to existing import 'javax.naming.AuthenticationException' 526
org/apache/shiro/session/mgt/AbstractValidatingSessionManager.java
Rule Violation Line
UselessParentheses Useless parentheses. 289
org/apache/shiro/session/mgt/SimpleSession.java
Rule Violation Line
UselessParentheses Useless parentheses. 388
UselessParentheses Useless parentheses. 389
org/apache/shiro/subject/SimplePrincipalMap.java
Rule Violation Line
UselessParentheses Useless parentheses. 236
UselessParentheses Useless parentheses. 257
UselessParentheses Useless parentheses. 274
org/apache/shiro/util/AntPathMatcher.java
Rule Violation Line
UselessParentheses Useless parentheses. 79
UselessParentheses Useless parentheses. 93
UselessParentheses Useless parentheses. 149–150
UselessParentheses Useless parentheses. 210
UselessParentheses Useless parentheses. 211
UselessParentheses Useless parentheses. 362
UselessParentheses Useless parentheses. 363
UselessParentheses Useless parentheses. 425
org/apache/shiro/util/ThreadContext.java
Rule Violation Line
UselessParentheses Useless parentheses. 137
UselessParentheses Useless parentheses. 192

Files

org/apache/shiro/SecurityUtils.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 56

org/apache/shiro/authc/SimpleAccount.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 466
UselessParentheses Useless parentheses. 4 484

org/apache/shiro/authc/SimpleAuthenticationInfo.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 285

org/apache/shiro/authc/pam/AllSuccessfulStrategy.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 85

org/apache/shiro/authz/SimpleRole.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 98
UselessParentheses Useless parentheses. 4 108

org/apache/shiro/jndi/JndiLocator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 66

org/apache/shiro/mgt/AbstractRememberMeManager.java

Rule Violation Priority Line
UnnecessarySemicolon Unnecessary semicolon 3 83

org/apache/shiro/mgt/DefaultSessionStorageEvaluator.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 63

org/apache/shiro/realm/ldap/JndiLdapContextFactory.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 473
CollapsibleIfStatements These nested if statements could be combined 3 514–529
UselessParentheses Useless parentheses. 4 522
UselessParentheses Useless parentheses. 4 523
UselessParentheses Useless parentheses. 4 524
UnnecessaryFullyQualifiedName Unnecessary use of fully qualified name 'javax.naming.AuthenticationException' due to existing import 'javax.naming.AuthenticationException' 4 526

org/apache/shiro/realm/text/PropertiesRealm.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 294–296

org/apache/shiro/session/mgt/AbstractValidatingSessionManager.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 289

org/apache/shiro/session/mgt/SimpleSession.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 388
UselessParentheses Useless parentheses. 4 389

org/apache/shiro/session/mgt/eis/MemorySessionDAO.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'LOGGER'. 3 58

org/apache/shiro/subject/SimplePrincipalMap.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 236
UselessParentheses Useless parentheses. 4 257
UselessParentheses Useless parentheses. 4 274

org/apache/shiro/util/AntPathMatcher.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 79
UselessParentheses Useless parentheses. 4 93
UselessParentheses Useless parentheses. 4 149–150
UselessParentheses Useless parentheses. 4 210
UselessParentheses Useless parentheses. 4 211
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 224
CollapsibleIfStatements These nested if statements could be combined 3 285–288
CollapsibleIfStatements These nested if statements could be combined 3 304–307
CollapsibleIfStatements These nested if statements could be combined 3 326–329
UselessParentheses Useless parentheses. 4 362
UselessParentheses Useless parentheses. 4 363
CollapsibleIfStatements These nested if statements could be combined 3 370–372
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 377
JumbledIncrementer Avoid modifying an outer loop incrementer in an inner loop for update expression 3 424–430
UselessParentheses Useless parentheses. 4 425

org/apache/shiro/util/ThreadContext.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 137
UselessParentheses Useless parentheses. 4 192

Processing Errors

Filename Problem
org/apache/shiro/env/BasicIniEnvironment.java PMDException: Error while parsing /Users/lprimak/dev/shiro/core/src/main/java/org/apache/shiro/env/BasicIniEnvironment.java 
net.sourceforge.pmd.PMDException: Error while parsing /Users/lprimak/dev/shiro/core/src/main/java/org/apache/shiro/env/BasicIniEnvironment.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:124)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:89)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:30)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: net.sourceforge.pmd.lang.java.ast.ParseException: Line 40, Column 26: Cannot use lambda expressions when running in JDK inferior to 1.8 mode!
	at net.sourceforge.pmd.lang.java.ast.JavaParser.throwParseException(JavaParser.java:30)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.checkForBadLambdaUsage(JavaParser.java:113)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.LambdaExpression(JavaParser.java:4986)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.PrimaryPrefix(JavaParser.java:4890)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.PrimaryExpression(JavaParser.java:4672)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.PostfixExpression(JavaParser.java:4494)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.UnaryExpressionNotPlusMinus(JavaParser.java:4392)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.UnaryExpression(JavaParser.java:4269)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.MultiplicativeExpression(JavaParser.java:4184)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.AdditiveExpression(JavaParser.java:4131)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ShiftExpression(JavaParser.java:4074)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.RelationalExpression(JavaParser.java:4013)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.InstanceOfExpression(JavaParser.java:3941)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.EqualityExpression(JavaParser.java:3686)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.AndExpression(JavaParser.java:3646)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ExclusiveOrExpression(JavaParser.java:3606)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.InclusiveOrExpression(JavaParser.java:3566)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ConditionalAndExpression(JavaParser.java:3526)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ConditionalOrExpression(JavaParser.java:3486)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ConditionalExpression(JavaParser.java:3448)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.Expression(JavaParser.java:3307)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ArgumentList(JavaParser.java:5497)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.Arguments(JavaParser.java:5451)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ExplicitConstructorInvocation(JavaParser.java:2570)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ConstructorDeclaration(JavaParser.java:2490)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ClassOrInterfaceBodyDeclaration(JavaParser.java:1851)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ClassOrInterfaceBody(JavaParser.java:1808)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ClassOrInterfaceDeclaration(JavaParser.java:936)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.TypeDeclaration(JavaParser.java:838)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.CompilationUnit(JavaParser.java:558)
	at net.sourceforge.pmd.lang.java.AbstractJavaParser.parse(AbstractJavaParser.java:62)
	at net.sourceforge.pmd.lang.AbstractParser.doParse(AbstractParser.java:45)
	at net.sourceforge.pmd.SourceCodeProcessor.parse(SourceCodeProcessor.java:136)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:200)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more
org/apache/shiro/session/mgt/ExecutorServiceSessionValidationScheduler.java PMDException: Error while parsing /Users/lprimak/dev/shiro/core/src/main/java/org/apache/shiro/session/mgt/ExecutorServiceSessionValidationScheduler.java 
net.sourceforge.pmd.PMDException: Error while parsing /Users/lprimak/dev/shiro/core/src/main/java/org/apache/shiro/session/mgt/ExecutorServiceSessionValidationScheduler.java
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:124)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:100)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCode(SourceCodeProcessor.java:62)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:89)
	at net.sourceforge.pmd.processor.PmdRunnable.call(PmdRunnable.java:30)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: net.sourceforge.pmd.lang.java.ast.ParseException: Line 117, Column 67: Cannot use lambda expressions when running in JDK inferior to 1.8 mode!
	at net.sourceforge.pmd.lang.java.ast.JavaParser.throwParseException(JavaParser.java:30)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.checkForBadLambdaUsage(JavaParser.java:113)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.LambdaExpression(JavaParser.java:4986)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.PrimaryPrefix(JavaParser.java:4890)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.PrimaryExpression(JavaParser.java:4672)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.PostfixExpression(JavaParser.java:4494)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.UnaryExpressionNotPlusMinus(JavaParser.java:4392)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.UnaryExpression(JavaParser.java:4269)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.MultiplicativeExpression(JavaParser.java:4184)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.AdditiveExpression(JavaParser.java:4131)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ShiftExpression(JavaParser.java:4074)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.RelationalExpression(JavaParser.java:4013)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.InstanceOfExpression(JavaParser.java:3941)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.EqualityExpression(JavaParser.java:3686)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.AndExpression(JavaParser.java:3646)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ExclusiveOrExpression(JavaParser.java:3606)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.InclusiveOrExpression(JavaParser.java:3566)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ConditionalAndExpression(JavaParser.java:3526)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ConditionalOrExpression(JavaParser.java:3486)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ConditionalExpression(JavaParser.java:3448)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.Expression(JavaParser.java:3307)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ArgumentList(JavaParser.java:5485)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.Arguments(JavaParser.java:5451)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.PrimarySuffix(JavaParser.java:5277)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.PrimaryExpression(JavaParser.java:4680)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.PostfixExpression(JavaParser.java:4494)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.StatementExpression(JavaParser.java:6145)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.Statement(JavaParser.java:5773)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.BlockStatement(JavaParser.java:5971)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.Block(JavaParser.java:5888)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.MethodDeclaration(JavaParser.java:2201)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ClassOrInterfaceBodyDeclaration(JavaParser.java:1855)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ClassOrInterfaceBody(JavaParser.java:1808)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.ClassOrInterfaceDeclaration(JavaParser.java:936)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.TypeDeclaration(JavaParser.java:838)
	at net.sourceforge.pmd.lang.java.ast.JavaParser.CompilationUnit(JavaParser.java:558)
	at net.sourceforge.pmd.lang.java.AbstractJavaParser.parse(AbstractJavaParser.java:62)
	at net.sourceforge.pmd.lang.AbstractParser.doParse(AbstractParser.java:45)
	at net.sourceforge.pmd.SourceCodeProcessor.parse(SourceCodeProcessor.java:136)
	at net.sourceforge.pmd.SourceCodeProcessor.processSource(SourceCodeProcessor.java:200)
	at net.sourceforge.pmd.SourceCodeProcessor.processSourceCodeWithoutCache(SourceCodeProcessor.java:118)
	... 10 more